opentelemetry-sdk: add experimental composable rule based sampler#4882
Merged
xrmx merged 10 commits intoopen-telemetry:mainfrom Feb 10, 2026
Merged
opentelemetry-sdk: add experimental composable rule based sampler#4882xrmx merged 10 commits intoopen-telemetry:mainfrom
xrmx merged 10 commits intoopen-telemetry:mainfrom
Conversation
anuraaga
reviewed
Jan 20, 2026
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Outdated
Show resolved
Hide resolved
…mental/_rule_based.py Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
…t_description While at it also provide AttributePredicate
anuraaga
approved these changes
Jan 21, 2026
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Show resolved
Hide resolved
herin049
approved these changes
Jan 26, 2026
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Show resolved
Hide resolved
github-project-automation
bot
moved this from Approved PRs
to Done
in @xrmx's Python PR digest
JWinermaSplunk
pushed a commit
to JWinermaSplunk/opentelemetry-python
that referenced
this pull request
Feb 17, 2026
…en-telemetry#4882) * opentelemetry-sdk: add experimental composable rule based sampler * Add CHANGELOG * Use a protocol for PredicateT * Update opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com> * Extend Predicate protocol to require __str__ and use it on sampler get_description While at it also provide AttributePredicate * Use a generator for getting predicates and descriptions * Add tests that matches with more than one rule --------- Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a composable rule based sampler to the experimental samplers.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: